[Yum-devel] [PATCH] Avoid converting to unicode and back in dump_xml_*. BZ 716235.

[Seth Vidal]

On Thu, 29 Nov 2012, Zdenek Pavlas wrote:

>> -            return zip(misc.to_unicode(self.hdr['changelogtime'], errors='replace'),
>> -                       misc.to_unicode(self.hdr['changelogname'], errors='replace'),
>> -                       misc.to_unicode(self.hdr['changelogtext'], errors='replace'))
>> +            return zip(self.hdr['changelogtime'],
>> +                       self.hdr['changelogname'],
>> +                       self.hdr['changelogtext'])
>
>> This is changing the types we are returning too.
>
> Just a note, changelogtime is integer, so to_unicode() had no effect whatsoever...
> I think the risk of breaking stuff by changing types of .changelog is small.



changelogname looks like:
Zdenek Pavlas <zpavlas at redhat.com> - 3.4.3-25opus:~$


so it can definitely be unicode in the name and definitely in the text.

I know the changelogname caused all sorts of hell at one point not b/c of 
unicode but b/c of another strange encoding.

latin-2? I don't remember the encoding straight off.

-sv