[Yum-devel] [PATCH] Avoid converting to unicode and back in dump_xml_*. BZ 716235.

Zdenek Pavlas zpavlas at redhat.com
Thu Nov 29 15:16:52 UTC 2012


> -            return zip(misc.to_unicode(self.hdr['changelogtime'], errors='replace'),
> -                       misc.to_unicode(self.hdr['changelogname'], errors='replace'),
> -                       misc.to_unicode(self.hdr['changelogtext'], errors='replace'))
> +            return zip(self.hdr['changelogtime'],
> +                       self.hdr['changelogname'],
> +                       self.hdr['changelogtext'])

> This is changing the types we are returning too.

Just a note, changelogtime is integer, so to_unicode() had no effect whatsoever...
I think the risk of breaking stuff by changing types of .changelog is small.


More information about the Yum-devel mailing list