[Yum-devel] [PATCH 3/4] pkglist: use streaming-friendly pkg split
James Antill
james at fedoraproject.org
Wed Nov 28 14:54:30 UTC 2012
On Wed, 2012-11-28 at 04:46 -0500, Zdenek Pavlas wrote:
> >> split_list_into_equal_chunks()
> > We can't remove this API. But we can change it to:
>
> Sure, can keep it there. Are there any users? Thought that
> two lines of code with one user are not worth it.
It's public API, so breaking it is much more expensive than just
leaving the function there.
> > ...what is the intention of changing the order?
>
> Using the original split e.g. [[1, 2, 3], [4, 5, 6]] we'd
> have to process the whole output of 1st worker before moving
> to the 2nd worker- which would be blocked all the time.
> With [[1, 3, 5], [2, 4, 6]] workers mostly run in parallel.
Ahh, I see. Can you add a doc. comment to the function to explain that
it's used on sorted input which is merged in order (hence the order
stuff comes out in)?
More information about the Yum-devel
mailing list