[Yum-devel] [PATCH] clean up misc.to_xml(), make it faster, add tests. BZ 716235.

[James Antill]

On Tue, 2012-11-20 at 09:21 -0800, Toshio Kuratomi wrote:

> Tested this procedure on f17 and got the same.  So it looks like in terms of
> what libxml2 can handle, we can't read what it produces if we're dealing
> with the C0 (ASCII) control codes.

 Yeh, I thought that was nice of it too :).

>   libxml2 both reads and writes the C1
> control codes that are present in unicode but not ascii.
> 
> Thoughts on continuing to ignore the C1 codes since libxml2 handles those?
> (This option would mean that the patch is essentially done.)

 Given how much to_xml() is called in the createrepo code paths, then
I'd vote that unless it's close to free we shouldn't bother.
 If it's in the 10-25% perf. hit, then I could be convinced that it's
better to do it anyway.