[Yum-devel] [PATCH] clean up misc.to_xml(), make it faster, add tests. BZ 716235.

[Toshio Kuratomi]

On Tue, Nov 20, 2012 at 09:54:16AM -0500, James Antill wrote:
> On Mon, 2012-11-19 at 15:24 -0800, Toshio Kuratomi wrote:
> > 
> > So it appears that strictly speaking it's only necessary to strip out
> > 0x00 to make libxml2 happy.
> 
>  I retried this on RHEL-5, assuming that would be "the worst" and it
> looked like it showed the same thing (only 0 disappeared), however if I
> redirected the output to a file and then moved that file back over to
> test.xml and ran it again:
> 
> test.xml:3: parser error : PCDATA invalid Char value 1
>   <test>1:
:
>           ^
> test.xml:4: parser error : PCDATA invalid Char value 2
> 2::
>   ^
> 
> ...and the same for value 3, 4, 5, 6, 7, 8, 11, 12, 14, 15, 16, 17, 18,
> 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31.
> 
> 
Tested this procedure on f17 and got the same.  So it looks like in terms of
what libxml2 can handle, we can't read what it produces if we're dealing
with the C0 (ASCII) control codes.  libxml2 both reads and writes the C1
control codes that are present in unicode but not ascii.

Thoughts on continuing to ignore the C1 codes since libxml2 handles those?
(This option would mean that the patch is essentially done.)

-Toshio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.baseurl.org/pipermail/yum-devel/attachments/20121120/cc7cf035/attachment.asc>