[Yum-devel] [PATCH] get retrycode *after* failure_callback has run

James Antill james at fedoraproject.org
Wed Jun 27 20:13:04 UTC 2012


On Wed, 2012-06-27 at 16:50 +0200, Zdeněk Pavlas wrote:
> ---
>  urlgrabber/grabber.py |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)

 This is so the failure handler can change it, right?

 And I assume the exceptions aren't in a singleton or something weird,
so if the handler calls urlgrabber it won't overwrite previous data?

 The only real problem I see here is that the callback has no good way
to know if it can/should change the exception data. I'm not sure it
matters enough though. ACK unless you can think of a better way :).



More information about the Yum-devel mailing list