[Yum-devel] [PATCH] quote uids to keep cachedir ascii-clean. BZ 832195

[James Antill]

On Tue, 2012-06-26 at 03:30 -0400, Zdenek Pavlas wrote:
> >  It solves the problem, but the commit messages says "uids" when it's
> > actually "username" ... and I _think_ sysadmins. would much prefer it
> > if we didn't quote here.
> 
> Sorry, i meant 'uid' as in rfc4519 (login name), not the numeric one,
> neither the (full) user name.

 Ahh, LDAP.

> >  Atm. we have stuff like:
> > 
> > yum-james-dwPkso/
> > 
> > ...and after this patch we'll have stuff like:
> > 
> > yum-j%C2%B9-dwPkso/
> 
> 'james' is ascii, so there should be no change (unless I miss something)
> I'm using this patch for a while, and it's still 'yum-zpavlas-Ol3yeF'..

 Yeh, that's true ... only people stupid enough to have non-ascii
usernames are affected in either case so it can certainly be argued that
whatever pain they experience is of their own making and we should just
do whatever is easiest :).

> > yum-[123]-dwPkso/
> > ...where "123" is their uid. Another option is to use the uid all the
> > time. Any opinions?
> 
> Two code paths are bad.  The nice thing with quoting is that it's no-op
> in most cases, so we don't pollute /var/tmp with two sets of directories.

 Well there are still two code paths, just that the "if" is hidden
inside urllib. But, meh. ... if you prefer it, ACK.