[Yum-devel] [PATCH] interrupt_callback=None: reraise instead of retrying

[James Antill]

On Wed, 2012-06-13 at 09:37 -0400, Zdenek Pavlas wrote:
> >  But then we have "KeyboardInterrupt" escaping from urlgrabber, no?
> >  What does that do?
> 
> No, if interrupt_callback=None, we catch KeyboardInterrupt
> and raise it only when there are no retries left.

 Ok, yeh ... so urlgrabber already raises it. We can fix it then by just
setting retries=1, right? Why would we want to force retries=1 for all
callers? (I'm not sure it's wrong, but I'm less sure it's good).

> >  In the case of getting metalink, doesn't urlgrabber act like there
> >  is one mirror ... so the default callback will dtrt too?
> 
> The default callback is in repo._grab, but _getMetalink() can't
> use that (we need URL list to set it up).

 Hmm ... I was just thinking of the cases where someone puts N urls in
the "metalink = " line, but yeh never mind.