[Yum-devel] [PATCH 1/3] Clean up class MultiFileHelper

[James Antill]

On Fri, 2011-08-26 at 03:56 -0400, Zdenek Pavlas wrote:
> >>      def _do_end(self, amount_read, now):
> >> -        self.ftotal_time = format_time(now - self.start_time)
> >> -        self.ftotal_size = format_number(self.last_amount_read)
> >>          self.master.end_meter(self, now)
> 
> > urlgrabber has a published API.. This is part of it.
> > We can't break it.
> 
> How one finds out what makes up the published API?
> Search for ftotal_time, ftotal_size, and urlgrabber
> gives nothing but the source.

 The rules are roughly what you'd expect:

1. Anything that doesn't start with "_" is part of the API, and can't be
incompatibly changed.

2. Anything that starts with "_", but is used significantly outside yum
also can't be changed incompatibly.

 Due to properties and default parameters etc. ... we have some room to
move within "compatible", but ofc. some callers (RHN/PK/etc.) intimate
knowledge of bits of yum often break that (Eg. the size= param. added to
_getFile).