[Yum-devel] [PATCH] Show if transactions have error output, in history list

[Seth Vidal]

On Thu, 25 Mar 2010, James Antill wrote:

> ---
> docs/yum.8 |    2 ++
> output.py  |    3 +++
> 2 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/docs/yum.8 b/docs/yum.8
> index ff7ed8f..00bfd53 100644
> --- a/docs/yum.8
> +++ b/docs/yum.8
> @@ -289,6 +289,8 @@ if there was something not good with the transaction.
> .br
> .I \fB#\fR - The transaction completed, but with a non-zero status.
> .br
> +.I \fBE\fR - The transaction completed fine, but had warning/error output during the transaction.
> +.br
>
> .IP
> .IP "\fBcheck\fP"
> diff --git a/output.py b/output.py
> index aa5dc4d..c4fde7c 100755
> --- a/output.py
> +++ b/output.py
> @@ -1310,6 +1310,9 @@ to exit.
>                 rmark = lmark = '*'
>             elif old.return_code:
>                 rmark = lmark = '#'
> +                # We don't check .errors, because return_code will be non-0
> +            elif old.output:
> +                rmark = lmark = 'E'
>             if old.altered_lt_rpmdb:
>                 rmark = '<'
>             if old.altered_gt_rpmdb:

ACK,

-sv