[Yum-devel] [PATCH] Use LOG_USER as default syslog facility everywhere in base.

[James Antill]

On Mon, 2010-03-22 at 21:02 +0200, Ville Skyttä wrote:
> On Monday 22 March 2010, James Antill wrote:
> > On Mon, 2010-03-22 at 19:57 +0200, Ville Skyttä wrote:
> > > ---
> > > 
> > >  yum/config.py |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/yum/config.py b/yum/config.py
> > > index ad8db7e..cb01306 100644
> > > --- a/yum/config.py
> > > +++ b/yum/config.py
> > > 
> > > @@ -601,7 +601,7 @@ class StartupConf(BaseConfig):
> > >      pluginconfpath = ListOption(['/etc/yum/pluginconf.d'])
> > >      gaftonmode = BoolOption(False)
> > >      syslog_ident = Option()
> > > 
> > > -    syslog_facility = Option('LOG_DAEMON')
> > > +    syslog_facility = Option('LOG_USER')
> > 
> >  Why? This has been the default for years.
> 
> "The default" seems to vary.  It's LOG_USER in 
> logginglevels.syslogFacilityMap() (fallback for unrecognized facilities) and 
> logginglevels.doLoggingSetup() (default if not set)

 Well apparently the default has always been LOG_USER, given that the
way we overrode it was broken. So I guess we should fix "the default" to
be what it was in practice, when we fix the override code.
 Apparently yum-updatesd always did it's own syslogging code, so that
worked.

 So ACK, I guess.