[Yum-devel] [PATCH] add exit_on_lock option for rh bug https://bugzilla.redhat.com/show_bug.cgi?id=598527

James Antill james at fedoraproject.org
Tue Jun 1 19:34:39 UTC 2010


On Tue, 2010-06-01 at 15:14 -0400, Seth Vidal wrote:
> if the lock is held, exit with value and output
> updated utils.py for this as well.
>
> settable on the cli with --setopt=...

 Another win for --setopt :)
 ACK, but...

> -            logger.critical(_("Another app is currently holding the yum lock; waiting for it to exit..."))
> -            show_lock_owner(e.pid, logger)
> -            time.sleep(2)
> +            if not base.conf.exit_on_lock:
> +                logger.critical(_("Another app is currently holding the yum lock; waiting for it to exit..."))
> +                show_lock_owner(e.pid, logger)
> +                time.sleep(2)
> +            else:
> +                logger.critical(_("Another app is currently holding the yum lock; exiting as configured by exit_on_lock"))
> +                return 1
>          else:
>              break

 Are you sure you want this bit? I think I'd prefer we either output the
same thing or nothing at all (as in, so that "yum -q" in cron doesn't
say anything).



More information about the Yum-devel mailing list