[Yum-devel] [PATCH] Move protect-packages plugin into core, and fix some bugs in it

[James Antill]

On Sun, 2010-04-25 at 10:46 -0400, Seth Vidal wrote:
> 
> On Sun, 25 Apr 2010, James Antill wrote:
> 
> > +    def _parse_protected_packages(self):
> > +        """ Find the protected packages by parsing the files in
> > +            /etc/yum/protected.d. yum is always protected. """
> > +        protected = set(['yum'])
> > +        for fname in glob.glob("/etc/yum/protected.d/*.conf"):
> > +            for line in open(fname):
> > +                if re.match('\s*(#|$)', line):
> > +                    continue
> > +                line = line.rstrip() # no more trailing \n's
> > +                line = line.lstrip() # be nice
> > +                if not line:
> > +                    continue
> > +                protected.add(line)
> > +        return protected
> > +
> 
> Why not just have a protected_packages = list of pkg names in 
> /etc/yum.conf?
> 
> Just like we have with install_only pkgs, etc, etc?
> 
> why have additional files AND dir for it?

 I thought it might be a good way to solve the python vs. python3
problem. We could get the python package to ship
an /etc/yum/protected.d/python file, and then as the package name
changed they'd just update that.

> > +    # VIEWS!
> 
> What does this have to do with anything?

 Nothing, just a comment from something else I was thinking about and
got caught with "commit -a".