[Yum-devel] [PATCH] Move protect-packages plugin into core, and fix some bugs in it

[Seth Vidal]

On Sun, 25 Apr 2010, James Antill wrote:

> +    def _parse_protected_packages(self):
> +        """ Find the protected packages by parsing the files in
> +            /etc/yum/protected.d. yum is always protected. """
> +        protected = set(['yum'])
> +        for fname in glob.glob("/etc/yum/protected.d/*.conf"):
> +            for line in open(fname):
> +                if re.match('\s*(#|$)', line):
> +                    continue
> +                line = line.rstrip() # no more trailing \n's
> +                line = line.lstrip() # be nice
> +                if not line:
> +                    continue
> +                protected.add(line)
> +        return protected
> +

Why not just have a protected_packages = list of pkg names in 
/etc/yum.conf?

Just like we have with install_only pkgs, etc, etc?

why have additional files AND dir for it?



> --- a/yum/history.py
> +++ b/yum/history.py
> @@ -649,6 +649,7 @@ class YumHistory:
>      pkgtupid INTEGER NOT NULL REFERENCES pkgtups);
> ''']
>
> +    # VIEWS!

What does this have to do with anything?

-sv