[Yum-devel] [PATCH] new dump_xml methods for repodata and repomd and related changes

Seth Vidal skvidal at fedoraproject.org
Wed Apr 14 20:24:34 UTC 2010



On Wed, 14 Apr 2010, Seth Vidal wrote:

>
>
> On Wed, 14 Apr 2010, James Antill wrote:
>
>> On Wed, 2010-04-14 at 16:11 -0400, Seth Vidal wrote:
>>>      def __init__(self, elem):
>>> -        self.type = elem.attrib.get('type')
>>> +        self.type = None
>>> +        if elem:
>>> +            self.type = elem.attrib.get('type')
>> 
>> Why not make the param default to None, if we make that valid?
>> 
>
> fair point.
>

is that an ACK with that change?

-sv



More information about the Yum-devel mailing list