[Yum-devel] [PATCH 2/3] Do the pkgmatch_fails negative caching, in _search

[Seth Vidal]

On Mon, 12 Apr 2010, James Antill wrote:

> On Mon, 2010-04-12 at 13:07 -0400, Seth Vidal wrote:
>
>> anything wrong with:
>>
>> if name and name in self._pkgmatch_fails:
>
> Well all the other code in that function uses "name is not None", on
> the other hand I seriously doubt anyone is passing a name of '' :)
>
>> the 'is not None' thing I've tried to stop using b/c it gets in weird
>> trouble with funky object types.
>
> I'm not sure what you mean ... as far as I know no object can return
> true for "is None"?
>

NoneType objects can, iirc.

and do we want pkgnames like ''?

which is not NONE but...

-sv