[Yum-devel] [PATCH 2/2] Clean up some unnecessary/redundant code.

Ville Skyttä ville.skytta at iki.fi
Mon Apr 12 15:37:14 UTC 2010


On Monday 12 April 2010, James Antill wrote:

>  My guess is that the hash was used for sorting/grouping. But there's no
> sort in the second ftimehash, which is weird ... and we resort the
> packages on output anyway, and I hope nobody would count this as an
> API...

Yep, that's what I thought too.

>  ACK.

I'll count this as an ack for the other change in this patch as well, 
hopefully you don't mind.

Just for the record, I wouldn't generally bother with things like these two.  
But I've had a patch for a long time that gets rid of remaining usages of 
has_key() (which I'll submit separately RSN) and these two were kind of while-
at-it byproducts done a long time ago that I thought would not be appropriate 
to bundle in the bulk of the rest of the has_key() removal patch and I didn't 
feel like throwing them away either.


More information about the Yum-devel mailing list