[Yum-devel] [PATCH] Fix import cleanup fallout (commit e2d9da3).
Seth Vidal
skvidal at fedoraproject.org
Wed Sep 30 18:49:54 UTC 2009
On Wed, 30 Sep 2009, Ville Skyttä wrote:
> This patch fixes a few low hanging "NameError: global name 'yum' is not
> defined" and the like issues I ran into today when doing a ./yummain.py
> upgrade (those were the yum.history reference in yum/__init__.py and some of
> the the yum.misc ones in yum/history.py) and hopefully fixes a few more of the
> kind.
>
> This is not meant to be exhaustive fix for all these issues - as said, just a
> few ones I ran into and a few others blindly fixed nearby in the code. "grep
> -r '\byum\.' *" shows more potential problems.
I was wrong about all this - Tim is correct it breaks py3 which is going
to be a whole bunch of pain and it looks like we break a bunch of other
random bits.
So I've reverted the patch and we'll need to further it to make sure we're
import yum. everywhere we're not explicitly mentioning it.
thank you for the patch, though, sorry I made things break.
-sv
More information about the Yum-devel
mailing list