[Yum-devel] [PATCH] Don't traceback on TS_FAILED txmbrs comming out of the transaction

James Antill james at fedoraproject.org
Tue Sep 22 18:59:09 UTC 2009


On Tue, 2009-09-22 at 18:34 +0200, Tim Lauridsen wrote:
> On 09/22/2009 05:47 PM, James Antill wrote:
> > +        assert state is not None
> >    
> Why this one ?

 Because that function (trans_data_pid_beg) is only called before the
transaction runs, and txmbr's shouldn't be added to the transaction with
TS_FAILED ... I'd hope :). Also if it triggered it's much less bad,
because we haven't run the transaction yet (whereas trans_data_pid_end
is called in the middle of the transaction).
 It isn't going to run in real Fedora builds anyway, as it'll be running
the .pyo version ... so it's just a present for us :).

-- 
James Antill <james at fedoraproject.org>
Fedora


More information about the Yum-devel mailing list