[Yum-devel] [PATCH 2/2] also remove filerequires if we have the file

[James Antill]

On Wed, 2009-10-28 at 11:32 -0400, Seth Vidal wrote:
> ---
>  yum/packages.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/yum/packages.py b/yum/packages.py
> index d9baa59..891bd6d 100644
> --- a/yum/packages.py
> +++ b/yum/packages.py
> @@ -999,7 +999,7 @@ class YumAvailablePackage(PackageObject, RpmBase):
>              if name.startswith('rpmlib('):
>                  continue
>              # this drops out requires that the pkg provides for itself.
> -            if name in self.provides_names:
> +            if name in self.provides_names or name in self.filelist + self.dirlist:

 This should include ghostlist too, yeh?

 Also these lists (provides_names, filelist, ditlist and ghostlist) are
built each time they are accessed, and are plain lists. Probably want to
save them and make a set().

>                  if not flags:
>                      print 'skipping req %s' % name
>                      continue

 Otherwise, ACK.