[Yum-devel] [PATCH] Replace some cmp based sorts with key based ones.

[Ville Skyttä]

On Monday 19 October 2009, James Antill wrote:
> On Sun, 2009-10-18 at 13:33 +0300, Ville Skyttä wrote:
> > ---
> >  cli.py          |    2 +-
> >  yum/comps.py    |   13 ++-----------
> >  yum/depsolve.py |   36 ++++++++++++++----------------------
> >  3 files changed, 17 insertions(+), 34 deletions(-)
> 
>  I tried to look at it all, and I think it does the same thing. But what
> is the rationale, just cleanness or a perf. improvement?

Both (although I haven't actually measured the performance effect), plus that 
cmp based sorts like these no longer exist in Python 3.

>  Otherwise, assuming you've installed something that hits
> compare_provides.

I have, and the test suite stresses this logic pretty well too.

>  ACK.

Thanks for the review.