[Yum-devel] [PATCH] Drop self._pkgtup2pkgs cache, leak checker to the rescue again

[James Antill]

On Tue, 2009-10-13 at 12:44 -0400, Seth Vidal wrote:
> 
> On Tue, 13 Oct 2009, James Antill wrote:
> 
> > ---
> > yum/sqlitesack.py |    1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/yum/sqlitesack.py b/yum/sqlitesack.py
> > index ce2988f..bc4b0ab 100644
> > --- a/yum/sqlitesack.py
> > +++ b/yum/sqlitesack.py
> > @@ -478,6 +478,7 @@ class YumSqlitePackageSack(yumRepo.YumPackageSack):
> >         self._key2pkg = {}
> >         self._pkgname2pkgkeys = {}
> >         self._pkgnames_loaded = set()
> > +        self._pkgtup2pkgs = {}
> >         self._search_cache = {
> >             'provides' : { },
> >             'requires' : { },
> 
> 1. what leak checker are you using?
> 2. what was breaking here?
> 
> it seems fine otherwise, though.

./test/yum-leak-test.py

...we tend to get a report every now and again from someone who creates
multiple YumBase() objects, when we start leaking. Apart from that it's
just extra resource consumption we don't need (which is why we never
notice until someone complains or runs the leak checker :).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.baseurl.org/pipermail/yum-devel/attachments/20091013/85e481c1/attachment.pgp>