[Yum-devel] Issues in the yum.conf.5 and yum.8 man pages

[James Antill]

On Sun, 2009-12-27 at 00:35 +0800, Thomas Goirand wrote:
> Hi,
> 
> man --warnings is complaining about issues in the manpages of version
> 3.2.25 of yum. It would be really nice if you guys were testing against
> man before releasing,

 The problem is that the man command you gave just prints a usage
warning on Fedora. I'm guessing you have a different version of man in
Debian? If you could supply something we could run in Fedora to check
the man pages, we'll happily run it.

>  as this creates warnings that are preventing me
> from uploading inside Debian if I don't patch the manpages. Here's the
> issues:

 These should all be fixed in:

http://yum.baseurl.org/gitweb?p=yum.git;a=commitdiff;h=26f4a8f7f441239d1e8ff28d26a700b1869aee82

> In yum.8, there is this text:
> 
> The format of the output of yum list is:
> 
> name.arch \[epoch\:\]version-release  repo or \@installed-from-repo
> 
> when I check for it, it does:
> 
> # LANG=C MANWIDTH=80 man --warnings -E UTF-8 -l yum.8 >/dev/null
> <standard input>:367: `\:' is not allowed in an escape name
> 
> I have no idea what was intended here, or how to fix, but this should be
> fixed for sure. Maybe \[epoch\:\] is a known keyword in Fedora 11, and
> not yet in SID. Can someone check in Fedora? Any idea how to fix?

 It wasn't displaying at all in Fedora, so I just removed all the \ ...
and it worked. Hope that fixes it for you.

> Also, line 292 of docs/yum.conf.5, there's:
> --version
> 
> when it should be:
> \-\-version

 Fix, along with a couple of other --blah cases in yum.8.

> Another thing that I still have in my patch list is the patch that I
> have attached to this message. Do you know if I could avoid such patch?
> It's just forward ported from previous maintainer, so I'm not even 100%
> sure that it's needed. Your comments would be appreciated on that one
> too. If we clean all the above, then my Debian package will be
> patch-free, which is always quite a nice thing.
> 
> Thanks for your attention,
> 
> Thomas Goirand
> plain text document attachment
> (0002-Make-compatible-with-SQLite.dpatch)
> #!/bin/sh /usr/share/dpatch/dpatch-run
> ## 0002-Make-compatible-with-SQLite.dpatch by Manuel Amador (Rudd-O) <rudd-o at rudd-o.com>
> ##
> ## DP: Forward-ported old sqlite patch to make it compatible with SQLite
> 
> @DPATCH@
> diff --git a/yum/sqlutils.py b/yum/sqlutils.py
> index 58b63ab..0605cf7 100644
> --- a/yum/sqlutils.py
> +++ b/yum/sqlutils.py
> @@ -162,10 +162,9 @@ def executeSQLQmark(cursor, query, params=None):
>      
>      return cursor.execute(query, params)
>  
> -if sqlite.version_info[0] > 1:
> -    executeSQL = executeSQLQmark
> -else:
> -    executeSQL = executeSQLPyFormat
> +# debian's pysqlite2 is built against sqlite3
> +executeSQL = executeSQLQmark
> +

 What this is doing is saying "if we are using pysqlite1, we must do the
QMark stuff internally ... otherwise let sqlite do it". This makes yum
work on python-2.4.x (aka. RHEL-5).
 What your comment seems to be saying is that pysqlite1 on Debian is
built against a version of sqlite that has QMark support (although the
English comment is confusing, I assume that's due to sqlite vs. sqlite3
thing), so you remove the test.

-- 
James Antill - james at fedoraproject.org
http://yum.baseurl.org/wiki/releases
http://yum.baseurl.org/wiki/whatsnew/3.2.25
http://yum.baseurl.org/wiki/YumMultipleMachineCaching