[Yum-devel] [PATCH] Remove unnecessary 'Finished Transaction Test' from CLI output.

[Ville Skyttä]

On Thursday 10 December 2009, Seth Vidal wrote:
> On Thu, 10 Dec 2009, Ville Skyttä wrote:
> > The outcome of the test is printed immediately after that anyway which
> > should be a good enough hint that the test finished.
> > ---
> > cli.py |    4 +---
> > 1 files changed, 1 insertions(+), 3 deletions(-)
> >
> > diff --git a/cli.py b/cli.py
> > index 8f50541..a70224d 100644
> > --- a/cli.py
> > +++ b/cli.py
> > @@ -455,9 +455,7 @@ class YumBaseCli(yum.YumBase, output.YumOutput):
> >         self.populateTs(keepold=0) # sigh
> >         tserrors = self.ts.test(testcb)
> >         del testcb
> > -
> > -        self.verbose_logger.log(yum.logginglevels.INFO_2,
> > -            _('Finished Transaction Test'))
> > +
> >         if len(tserrors) > 0:
> >             errstring = _('Transaction Check Error:\n')
> >             for descr in tserrors:
> 
> This was added when the rpmdb would occasionally lockup and stall us out
> so the user could tell ANYTHING about where we might be.

Where could it lock up between logging "Finished Transaction Test" and either 
raising "Transaction Check Error: ..." or logging "Transaction Test 
Succeeded"?  While generating errstring for the error case, or before the 
raised exception gets logged somewhere else?

> If it doesn't hurt anything, why would we get rid of this?.

Less is more.  Assuming of course it is no longer necessary.