[Yum-devel] [PATCH] get cmdline and parse out files on it to look for other items running

[Seth Vidal]

On Thu, 10 Dec 2009, Ville Skyttä wrote:

> On Thursday 10 December 2009, Seth Vidal wrote:
>
>> -    for line in maps.readlines():
>> +    for line in maps.readline():
>
> Hmm, this looks suspicious.  Wouldn't that just iterate over the chars on the
> first line, instead of over the actual lines?

good catch. Yah - I should be using xreadlines() I suspect to make sure 
I'm not reading all of it into memory at once.

-sv