[Yum-devel] First "usable" yum history patches

[James Antill]

On Wed, 2009-08-26 at 11:48 -0400, Seth Vidal wrote:
> 
> On Tue, 25 Aug 2009, James Antill wrote:
> 
> > Ok, here's the first look at the history stuff. I've tested it a bit,
> > and it seems to provide roughly the correct functionality. Here are the
> > known issues in rough order of importance:
> 
> 
> Overall this patch set looks good
> 
> A few comments:
> 
> repeat and undo in yumcommands:
>   1. they scare the hell out of me as to what users will expect from them
>   2. they seem out of place in yumcommands - I think they should probably 
> be stubs in yumcommands but shifted over to YumBase or inside the history 
> class itself. If only b/c someone will want to implement them from another 
> interface and there is no use having the code duplication that we will 
> inevitably have.
> 
> all the formatting output in yumcommands.py for the history commands 
> should probably be moved to output.py to keep yumcommands relatively 
> simple.

 I've done both of the above things, and a few other fixes/updates
(including the warning if the rpmdb is altered :).
 I've updated the big patch:

http://james.fedorapeople.org/yum/patches/history-BIG.patch

...or you can see all the individual commits from my git repo. (history
branch).

-- 
James Antill <james at fedoraproject.org>
Fedora