[Yum-devel] [PATCH 2/2] When installing for obsoletes, see if newer pkg is in trans. (BZ 516577)

[James Antill]

On Mon, 2009-08-17 at 16:52 -0400, Seth Vidal wrote:
> 
> On Mon, 17 Aug 2009, James Antill wrote:
> 
> > Otherwise we install two different versions, if the newer pkg doesn't
> > also do the obsoletes (stupid, stupid, packaging).
> 
> okay this makes me angry.
> 
> This is a packaging bug. Simple, Nothing else.

 Yeh, mostly.

> Why are we fixing this packaging bug?

 Well I think we need to do something so that yum doesn't try and
install two version of the same package ... I care less about what we do
though.

> I can even see us emitting a message like:
> 
> "The older version obsoletes this pkg correctly, but the newer one 
> doesn't. Please hit the packager with something heavy in bugzilla."
> 
> or does this fall into the "because we can we have to" category of things?

 So here's a rough summary of what we have and our options:

	what we have

  available

pkgA-1
  Obsoletes: pkgB
  Conflicts: pkgB
pkgA-2
  Conflicts: pkgB

  installed

pkgB-4

	options for "install pkgA"

1. Pretend pkgA-1 doesn't exist, so that "install pkgA" will die with
conflicts.

2. Pretend pkgA-2 doesn't exist, so that "install pkgA" will install
pkgA-1, and obsolete pkgB.

3. Try and install pkgA-2 and then auto-assume the obsoletes from pkgA-1
to get out of the conflicts.

4. Try and install pkgA-2 and then try and install pkgA-1 to get out of
the conflicts (and then rpm dies).

5. Something else, like "quietly fail" the install.


...atm. we do #4 which at least looks like we screwed up.
 People seem to want #3 (though why they broke the packaging I don't
know), and that's what I did. I tried to implement #1 for comparison,
but didn't have any success.
 #2 is what happens for a plain "update", but to make that happen for
"install pkgA" I think we'll need to mark pkgA-2 for install and then
move back down to pkgA-1 ... which is pain.

 I mostly hate it too, and I'll happily ack something if you have a
patch to make #1 happen ... but I'm more partial to just doing what
people want (with color!:) than spending any more time trying to make #1
happen.

</incoherent rambling>

-- 
James Antill <james at fedoraproject.org>
Fedora