[Yum-devel] _compare_providers() and testcases

Hans-Peter Jansen hpj at urpla.net
Wed Apr 2 08:55:19 UTC 2008


Am Mittwoch, 2. April 2008 schrieb seth vidal:
> Hey folks,
>  We found a bunch of brokeness in the _compare_providers() method
> introduced in 3.2.13. Lots of oddball cases and some loops that happen
> for odd reasons. So after some discussion in gibbering in corners we
> decided to score each providing package vs the other package then take
> the package with the best score.
>
> The patch that does this is here:
>
> http://skvidal.fedorapeople.org/patches/yum-compare_providers-scoring.pat
>ch

I've applied it to yum version 07577aed00d900cdcf24ae60bf3006efe164cacc.

> However, when I run the test cases I get 5 failed tests
>
> 1 of them is unrelated. It's related to update() needing some more magic
> 2 of them appear to be a multilib case not sorting properly, which I'm
> working on fixing now.
> 3 of them appear to be bogus assertions in the testcases, at least as
> how I'm reading them.
>
> apply the above patch and give the test cases a run, let me know what
> you think.

If thrown on my pathologic case, the result is attached. In short: problem 
persists.

Let me know, if you need more details..

Pete
-------------- next part --------------
A non-text attachment was scrubbed...
Name: yum-3.2.14-update-git-20080402.log.bz2
Type: application/x-bzip2
Size: 4863 bytes
Desc: not available
Url : http://lists.baseurl.org/pipermail/yum-devel/attachments/20080402/af8fa0f5/attachment.bin 


More information about the Yum-devel mailing list