[Yum-devel] [PATCH][RFC] whatProvides to getProvides

Florian Festi ffesti at redhat.com
Fri Nov 30 14:26:31 UTC 2007


seth vidal wrote:
> On Fri, 2007-11-30 at 15:14 +0100, Florian Festi wrote:
>> Hi!
>>
>> Attached patch cleans up the code a bitz by moving from whatProvides to 
>> getProvides. It also uses getProvides to implement whatProvides.
>>
>> Only interesting issue is that it circumvents the 
>> YumBase.doSackFilelistPopulate() call and leaves the stup of the filelist to 
>> the underlaying Sack objects. This shouldn't be a problem but may 
>> change/reduce the debugging/info output.
>>
>> Can someone please comment if this is a problem?
>>
>> Additionally this raises the question is if doSackFilelistPopulate() is 
>> needed at all.
>>
> 
> What does this do to the callback when the sack is being populated?

doSackFilelistPopulate() calls repos.populateSack(mdtype='filelists') 
without passing a callback. Is there any other callback to take care of?

Florian



More information about the Yum-devel mailing list