[Yum-devel] [PATCH] Fix arch behavior for versioned obsoletes

[Tim Lauridsen]

Florian Festi wrote:
> Florian Festi wrote:
>> Florian Festi wrote:
>>> Hi!
>>>
>>> Attached patch completes the behavior change Jeremy introduced with 
>>> 5badc2b67b9885d2993b6f77423bc632b8595b01 - "when an obsolete is 
>>> available for a package, only install most matching arch rather than 
>>> all available arches (rh#301661)". Currently arch is ignored for 
>>> versioned obsoletes as the now added lines are missing in that code 
>>> path. Please commit!
>>>
>>> There is a test case in my "gold" branch but the patch depends on 
>>> other patch sets in that branch - feel free to pull them in.
>>>
>>> Special thanks to Zdenek Kabelac for reporting that problem and 
>>> Thomas Wörner for hunting it down.
>>
>> A probably better way to fix this is to avoid different code path at 
>> all. Attached patch removes the code duplication in doObsoletes() and 
>> fixes the versioned obsoletes problem en passant.
> 
> If there are no objections I am going to commit this fix and the 
> corresponding test case.
> 
> Florian
> _______________________________________________
> Yum-devel mailing list
> Yum-devel at linux.duke.edu
> https://lists.dulug.duke.edu/mailman/listinfo/yum-devel

Look fine to me.

Tim