[Yum-devel] [Patch] Resolver Performance and Correctness

Jeremy Katz katzj at redhat.com
Wed Jun 6 15:21:37 UTC 2007


On Wed, 2007-06-06 at 11:34 +0200, Florian Festi wrote:
> Jeremy Katz wrote:
> > On Tue, 2007-06-05 at 13:22 +0200, Florian Festi wrote:
> >>     * adjusted interface of PackageSackBase.matchPackageNames()
> >>       to other Sacks
> >>      * Does this break anything?
> > 
> > This should be safe.  Or if it's not, it's already going to be breaking
> > things :)  But it's been like this since 3.0.x, so probably fine
>
> Needed to allow PackageSackBase being part of a MetaSack. Patch attached

This looks good to me; as I said, PackageSackBase doesn't match any of
the other PackageSacks and hasn't for quite a while so I don't think
anything was depending on the case matching.  Other opinions?  The other
way to go would be to add case matching to all of the matching...

Jeremy




More information about the Yum-devel mailing list