[Yum-devel] [Patch] Resolver Performance and Correctness

[Florian Festi]

Thanks for your feedback, Jeremy. To get this whole thing structured (and to 
keep the latency below a week) I'll answer the single issues in single mails.

Jeremy Katz wrote:
> On Tue, 2007-06-05 at 13:22 +0200, Florian Festi wrote:
>>   * SqliteSack
>>    * .prco uses empty tuple as default value
>>      to destinct from empty list and avoid multiple db queries
>>    * _search_cache
> 
> Didn't you previously have a patch to do this with None instead of an
> empty tuple?  Also, what memory cost does the _search_cache end up
> having?
> 
> Jeremy

True. I moved to empty tuples as they are the closest distinguishable 
replacement for an list. So the idea is that they cause less problems than 
None as they also allow test for inclusion, iteration and so on. I admit 
that issuing an error when accessing the not yet loaded prco lists may be 
wanted. But this is an different issue.

Single patch is attached. It also simplyfies the SQL statement which should 
give another small speedup.

I have to admit that I did not yet do much tests/benchmarks on the caches. I 
just added them to have a replacement for Depsolve.deps. Tweaking the 
caches, dropping them again or replacing them by LRU lists should IMHO be 
done if everything else is settled.

Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: yum-load_prco_once-2.diff
Type: text/x-patch
Size: 1955 bytes
Desc: not available
Url : http://lists.baseurl.org/pipermail/yum-devel/attachments/20070606/f0232301/attachment.bin