[Yum-devel] [PATCH][RFC] Optimizing SqliteSack

[seth vidal]

On Tue, 2007-12-18 at 18:00 +0100, Florian Festi wrote:

> I changed Package.hash to ._hash to avoid API clutter. Responsiveness in 
> file-resolutions shouldn't be affected by the ._files change. Filelists 
> aren't loaded anyway. Or are you talking about the searchFiles implementation?

For people searching files the bad way (by iterating the filelists of
all packages). I was just making sure we're not stepping on anything
there.


> >>   * Package
> >>    * Make Package.pkgtup a real tuple
> > 
> > How much testing has this portion of the patch seen? I ask b/c I
> > remembered trying to switch away from the pkgtup property before. IIRC,
> > the wheels fall off when you use the objects in interesting ways.
> 
> I really would like to try this as it saves a lot of time and memory. For a 
> F8 full install it saves 120000 tuples. Anyone else have an idea what to 
> check to find possible problems?

I'm inclined to believe it won't be a problem and it probably comes from
a time pre-property(). So merge the patch in but keep your ears open for
bugs in some of our calling apps, just in case.

-sv