[Yum-devel] [PATCH][RFC] Optimizing SqliteSack

Tim Lauridsen tim.lauridsen at googlemail.com
Wed Dec 19 14:47:32 UTC 2007


> 
>>>   * Package
>>>    * Make Package.pkgtup a real tuple
>>
>> How much testing has this portion of the patch seen? I ask b/c I
>> remembered trying to switch away from the pkgtup property before. IIRC,
>> the wheels fall off when you use the objects in interesting ways.
> 
> I really would like to try this as it saves a lot of time and memory. 
> For a F8 full install it saves 120000 tuples. Anyone else have an idea 
> what to check to find possible problems?

The only thing i can think off is

if pkgtup is property then it is readonly, if no fset is defined and it 
will give the right pkgtup, even if the nevra of the package is changed.
but i dont can find any situation where the nevra should be changed on 
an existing package object, so it should be safe enough.
if api users are over writting the pkgtup of a package object, they are 
asking for trouble.

I cant thing of any "real" situation, where changing pkgtup from a 
property, to a reel object variable, should break anything.

API users should only use pkgtup to read the
(n,e,v,r,a) tuple and nothing else.

Tim



More information about the Yum-devel mailing list