[Yum-devel] RFC: Spaces in a repositoryid?

[seth vidal]

On Sun, 2007-12-16 at 15:30 -0500, James Antill wrote:
> On Sun, 2007-12-16 at 12:56 -0500, seth vidal wrote:
> > On Sun, 2007-12-16 at 08:49 +0100, Tim Lauridsen wrote:
> > > James Antill wrote:
> > > >  So currently the yum.conf documentation says:
> [...]
> > > > ...which heavily implies that "repositoryid" must not contain spaces,
> > > > [...] but I've just created the attached patch which changes
> > > > that, as you now won't be able to use --disableexcludes with a repoid
> > > > that has a space in it[2].
> > > >  So should we just ignore this, allow whitespace in repoid's ... or add
> > > > some code to check the repoid for valid chars (and then warn)?
> [...] 
> > > Im not sure this is a good idea, there is a lot of stuff out there can 
> > > break if you introduce spaces in repo ids.
> > > and --enablerepo/--disablerepo becomes a little weird.
> > > 
> > > yum --disablerepo="ny own repo, my other repo" install foobar
> > > 
> > > that is wrong with my-own-repo or my_other_repo.
> > > I don't think it is worth it, it increases the possibility of errors a lot.
> > 
> > +1
> > 
> > I don't think we want to add this. We may even want to be more
> > restrictive about what can be in a repoid. For example: no /'s no ..'s.
> > We make directories based on the repoid name.
> 
>  I guess it wasn't obvious, but I was arguing for 3) Start warning
> people about repoid's that aren't just a simple word. or 1) Just ignore
> it, and have most things work, but repoid's still be documented to not
> have whitespace etc.
> 
>  My main concern was that I would checkin the patch, which doesn't work
> with repoid's that have whitespace and someone would complain that they
> had a weird repoid that has a space in it.
> 
>  So is everyone in agreement that the patch is fine (for specifying
> multiple arguments), and that we should also warn people about weird
> repoid's? Should I put something in Repository.__init__?
>  Or am I confused about the above replies?
> 

okay, I think I was confused by it, then.

Why don't we make repoids be alphanumerics + -_ only?

Any objections?

-sv