[Yum-devel] RFC: Spaces in a repositoryid?

[seth vidal]

On Sun, 2007-12-16 at 08:49 +0100, Tim Lauridsen wrote:
> James Antill wrote:
> >  So currently the yum.conf documentation says:
> > 
> > [repository] OPTIONS
> >        The repository section(s) take the following form:
> > 
> >        Example:
> >               [repositoryid]
> >               name=Some name for this repository
> >               baseurl=url://path/to/repository/
> > 
> > 
> >        repositoryid
> >               Must be a unique name for each repository, one word.
> > 
> > ...which heavily implies that "repositoryid" must not contain spaces,
> > however creating a repoid with spaces in it currently works fine as far
> > as I know[1] ... but I've just created the attached patch which changes
> > that, as you now won't be able to use --disableexcludes with a repoid
> > that has a space in it[2].
> >  So should we just ignore this, allow whitespace in repoid's ... or add
> > some code to check the repoid for valid chars (and then warn)?
> > 
> >  Also if anyone objects to the patch in general, feel free to
> > comment :).
> > 
> > [1] I know this because I tried it for a while, before I read the
> > documentation :).
> > 
> > [2] AFAIK no well known repos have whitespace in them.
> > 
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > _______________________________________________
> > Yum-devel mailing list
> > Yum-devel at linux.duke.edu
> > https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
> 
> Im not sure this is a good idea, there is a lot of stuff out there can 
> break if you introduce spaces in repo ids.
> and --enablerepo/--disablerepo becomes a little weird.
> 
> yum --disablerepo="ny own repo, my other repo" install foobar
> 
> that is wrong with my-own-repo or my_other_repo.
> I don't think it is worth it, it increases the possibility of errors a lot.

+1

I don't think we want to add this. We may even want to be more
restrictive about what can be in a repoid. For example: no /'s no ..'s.
We make directories based on the repoid name.

-sv