[Yum-devel] Fix bug in erase behaviour

[James Bowes]

Hi Gijs:

Gijs Hollestelle wrote:
> I noticed a bug in the remove behaviour:
> yum is happy to remove kmod-nvidia-96xx while leaving
> xorg-x11-drv-nvidia-96xx which depends on nvidia-96xx-kmod >=
> 1.0.9631.
> 
> It turns out the code responsible for this is inPrcoRange in
> packages.py which contains the following code:
>                if f != 'EQ':
>                    # isn't this odd, it's not 'EQ' - it really should be
> 
> The fact that flags != 'EQ' is odd only holds for provides not for the
> other prco's.
> So I added an extra constraint here:
>                if f != 'EQ' and prcotype == 'provides':
> 
> Now you correctly removes xorg-x11-drv-nvidia-96xx as well in the test
> case.

inPrcoRange is covered by some test cases in test/packagetests.py. Would
you mind adding a test case/test cases for this bug?

-James "unit tests will solve all our problems Bowes

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
Url : http://lists.baseurl.org/pipermail/yum-devel/attachments/20070425/c5ee526d/attachment.pgp