[Yum-devel] [RFC][PATCH] config initialisation refactoring
Jeremy Katz
katzj at redhat.com
Tue Jun 13 18:51:44 UTC 2006
On Tue, 2006-06-13 at 19:31 +0100, Menno Smits wrote:
> I've refactored the way Yum's configuration and logging gets initialised
> because Jeremy and myself weren't happy with my recent changes in
> this area. I thought I'd better get this in quickly because I noticed
> people have been changing their code to match the new (ugly) API.
Mostly because some of us are trying to do things with yum HEAD at the
moment. But it's with the understanding that things may have to change
more than once... that's the fun of a devel series :)
> This patch removes the doStartupConfig() method that was recently added
> by merging most of what it did into doConfigSetup(). doConfigSetup() now
> sets up plugins and logging by calling overridable doPluginSetup() and
> doLoggingSetup() methods. A few other minor bits and pieces were cleaned
> up as well. In most cases client code shouldn't need to call
> doPluginSetup() anymore although it can if required.
>
> I think this approach is cleaner and more flexible. Any comments before
> I commit?
Looks sane at a glance to me... it's basically the approach I'd been
thinking would make the most sense.
Jeremy
More information about the Yum-devel
mailing list