[Yum-devel] [Patch 0/3] Enabling work for yum capable of cdrom handling

[Menno Smits]

Hi Paul,

Paul Nasrat wrote:
> This series of patches is part of the work to move the logic of handling
> CD's and split media installs into yum proper from anaconda.  This will
> enable users of the yum API such as pirut, yumex, and the yum cli to be
> able to use CDROMs.
> 
> This set of patches moves the SortableTransactionData into yum and
> enables subclasses to take advantage of it.

I've gone through these patches and they seem mostly ok.

I'm a bit confused about the sortColour attribute and the TX_* constants 
however. The sortColour attribute seems to be used to track the 
state/type of each transaction member but why refer to colours? I don't 
think UI related code makes sense at this level but I get the feeling 
the attribute and constants aren't really UI related.

There's also a typo: TX_TX_WHITE should be TX_WHITE.

Some docstrings would be nice too, at least for the 
SortableTransactionData class.

If you can clarify the sortColour situation, perhaps by renaming the 
constants and attribute (if that makes sense), then I'm happy for these 
patches to go in.

Menno