[Yum-devel] [PATCH] Bug in rpmUtils/transaction.py

[seth vidal]

On Thu, 2006-02-09 at 09:52 -0800, David Lutterkort wrote:
> [I sent this a while ago, but it seems to have fallen through the crack.
> Could somebody review and commit ? ]

The crack was called: Seth at LCA then on holiday.
:)

Sorry about that.


> 
> Hi,
> 
> transaction.py has a small bug in TransactionWrapper.returnLeafNodes as
> can be seen by comparing the output of 'rpm -q --whatrequires evolution' with that of
> 'package-cleanup --all --leaves | grep evolution'. The former shows that
> evolution is not required  by anything, the latter shows that
> package-cleanup does not consider evolution a leaf package.
>  
> The problem is that packages that require things that they also provide
> are not correctly recognized as leaf packages. The attached patch fixes
> that; it is a little complicated by dealing with the following
> situation: package A provides P and requires P, package B requires P -
> in that situation, A is not a leaf package. To deal with this correctly,
> the patch builds a dictionary from all the REQUIRE_NAMES to the _set_ of
> packages that have this requirement (instead of a random element of that
> set).
> 

Very small white-space error in the patch - otherwise merged, and thank
you.

-sv