[Yum-devel] [PATCH] Comps clarification

[Dennis Gregorovic]

On Fri, 2006-02-03 at 14:48 -0500, Paul Nasrat wrote:
> Whilst looking at the new comps format and our current comps.xml we
> decided that there is potential ambiguity around how we do things for
> language support.
> 
> Let me give a walk through of the discussion and our thoughts:
> 
> Simple default - all good: <packagereq type="default">bg5ps</packagereq>
> 
> Default with requires - these were originally optional but changed to
> default to enforce being pulled in.  Both of those are really suboptimal
> and we really want them to be pulled in if the requirement is met on the
> system/in the tsInfo:
> 
> <packagereq type="default" requires="kdelibs">scim-qtimm</packagereq>
> <packagereq type="default"
> requires="openoffice.org-core">openoffice.org-langpack-zh_CN</packagereq>
> 
> Proposed solution:
> 
> Take all cases where we use <packagereq ... requires= and create a new
> type:
> 
> <packagereq type="conditional"
> requires="openoffice.org-core">openoffice.org-langpack-cy_GB</packagereq>
[snip]

This looks sane.  My only concern is that as someone reading comps.xml,
that line doesn't make complete sense to me without knowing the context
described in your email.  Perhaps the "requires" attribute could be
"if_installed"?  Although I'm not sure that's any better...

By the way, could this conditional functionality be handled by the use
of the new Enhances: RPM tag at some point?

-- Dennis