[Yum-devel] [PATCH] two buglets

[seth vidal]

On Thu, 2006-12-07 at 22:43 +0100, Terje Rosten wrote:
> Just a patch to fix two buglets:
> 
> $ yum -y -d0 -e0 install gnupg | tee /tmp/yum.log
>  Updating  : gnupg                      ######################### [1/2]
> $
> 
> This simple command shows two buglets, first there should not be any
> output at all, and second if any output the Cleanup : ... line should
> be present, however it's missing. Patch also includes a tiny white
> space fix.
> 
> Please apply.
> 
>  - Terje
> 
> Index: callback.py
> ===================================================================
> RCS file: /cvsroot/yum/cvs/yum/callback.py,v
> retrieving revision 1.30
> diff -u -r1.30 callback.py
> --- callback.py	5 Dec 2006 00:40:51 -0000	1.30
> +++ callback.py	7 Dec 2006 21:29:54 -0000
> @@ -197,7 +197,7 @@
>                  logmsg = _('Erased: %s' % (h))
>                  self.logger.info(logmsg)
>              
> -            if self.output and sys.stdout.isatty():
> +            if self.output:
>                  if h not in self.installed_pkg_names:
>                      process = "Removing"
>                  else:


Can you check this out writing to a non-tty?

> Index: cli.py
> ===================================================================
> RCS file: /cvsroot/yum/cvs/yum/cli.py,v
> retrieving revision 1.246
> diff -u -r1.246 cli.py
> --- cli.py	5 Dec 2006 00:40:51 -0000	1.246
> +++ cli.py	7 Dec 2006 21:29:54 -0000
> @@ -229,7 +229,13 @@
>              
>              # Handle remaining options
>              if opts.assumeyes:
> -                self.conf.assumeyes =1
> +                self.conf.assumeyes = 1
> +
> +            if opts.debuglevel it not None:
> +                self.conf.debuglevel = opts.debuglevel
> +
> +            if opts.errorlevel it not None:
> +                self.conf.errorlevel = opts.errorlevel
>  
>              if opts.cacheonly:
>                  self.conf.cache = 1

I did the same thing as above on the plane today but I did it inside
config.py where it really should be set anyway.

see the yum-cvs-commits list for what I checked in.

And I committed your whitespace fix above. thank you.

-sv