[Yum-devel] [urlgrabber] keepalive broken

[James Bowes]

Florian Festi wrote:
> Hi!
> 
> Looks like the "SSL patch to use M2Crypto when available" breaks 
> keepalive. Problem is that fresh instances are inserted in to the 
> handlers list. This lets CachedOpenerDirector() fail to find a matching 
> opener. The attached patch fixes this problem by caching HTTPSHandlers 
> by ca_cert, ssl_context.

oops. Nice catch, Florian :)

> 
> I also added calls to the __init__() methods of urllib2 super classes of 
> HTTPHandler and HTTPSHandler.

IIRC, those were kept out intentionally, as calling them on python 2.3 
broke things.

-James