[Yum-devel] gpg importing script

[Menno Smits]

seth vidal wrote:
> Menno,
>  I just got a chance to test in use your gpg key import patch. It works
> ok - but one question:
> 
> Do you think we should disable the check for any installed keys if
> anything is marked gpgcheck=1 that happens early on?

I did think of this check when I was working on the gpgkey patch ... and 
then forgot about it :(

> Seeing as your patch makes importing the keys automatic there's almost
> no reason to have the catch.
> 
> I could make it so if gpgkey is not defined anywhere and gpgcheck=1 then
> throw up the warning.

I think this is the way to go. Something like:

if (there are no gpg keys in rpmdb) and
    ((gpgcheck is 1 globally and gpgkey is not set for any repo) or
     (gpgcheck=1 for a repo and gpgkey is not set for that repo)):
	display_warning()
  	exit()

The error text presented to the user should possibly mention gpgkey 
option as an alternative to "rpm --import". What do you think?

Do you want me to make the above change or do you want to do it?

Menno



Scanned by the NetBox from NetBox Blue
(http://netboxblue.com/)