[Yum-devel] PATCH: bandwidth limit option parsing

[Menno Smits]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

seth vidal wrote:
| On Sun, 2004-10-10 at 17:52 +1000, Menno Smits wrote:
|
|>-----BEGIN PGP SIGNED MESSAGE-----
|>Hash: SHA1
|>
|>Hi all,
|>
|>As discussed earlier on this yum-devel, please find attached a patch
|>that implements parsing for the yum.conf "bandwidth" and "throttle"
|>options.
|>
|>I've taken in to account Michael Stenner's comments about what sort of
|>bandwidth values should be accepted. All bandwidth values are in
|>bytes/sec with an optional SI prefix. To avoid confusion the case of the
|>prefix is ignored. "throttle" may be a percentage (eg. "50%") or a
|>bytes/sec value as accepted for "bandwidth".
|>
|>Valid and invalid values for the settings are documented at the top of
|>parseByteVal() and parseThrottle(). I will also update the yum.conf man
|>page to match.
|
|
| So I'm looking at this patch and I realize it's sorta in the wrong
| place.
|
| shouldn't these options be set per repository and not globally?
|
| b/c the grabbers are being setup per-repository, not globally.

Yep, you're right. I totally forgot about the per repo versions of these
settings. The way it works with this patch now is that the options in
[main] will be enforced for all repos. If per-repo settings are given
they will be read but will cause breakage as before because they aren't
parsed to numbers.

I'll fix it soon when I have time.

I think there should be global bandwidth and throttle options available
in [main] (in case you just want to limit the overall impact of yum on
your own link) and overrides of those defaults for each repo. Sound ok?

Regards,
Menno



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBbMRpWH92Dls5JXwRAtMjAJ9PIMG82YzS6rnpobwZKooybMlrKgCgitoK
/gUXgX/OmRohV7T0JzxqO7w=
=oI6U
-----END PGP SIGNATURE-----

Scanned by the NetBox from NetBox Blue
(http://netboxblue.com/)