[yum-commits] yum-builddep.py

[Panu Matilainen]

 yum-builddep.py |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a2881b22723e3cf025b1ec372ffcb8267b2c8b8c
Author: Panu Matilainen <pmatilai at laiskiainen.org>
Date:   Fri Sep 7 08:58:07 2012 +0300

    Fix multiple non-spec argument processing (BZ 855239)
    
    I doubt this ever actually worked, yum's bestPackagesFromList() appears
    to be intended for picking the best packages from a set of related
    packages, and in this case they're not even remotely related. Calling
    bestPackagesFromList() separately for each package fixes things for
    both src.rpm's in repositories and local src.rpms.

diff --git a/yum-builddep.py b/yum-builddep.py
index fa00414..b9e682a 100755
--- a/yum-builddep.py
+++ b/yum-builddep.py
@@ -227,10 +227,10 @@ class YumBuildDep(YumUtilBase):
                     sys.exit(1)
                     
         toActOn = []
+        # Get the best matching srpms
         for newpkg in srpms:
-            toActOn.extend(_best_convert_pkg2srcpkgs(self, opts, newpkg))
-        # Get the best matching srpm
-        toActOn = self.bestPackagesFromList(toActOn, 'src')
+            srcpkg = _best_convert_pkg2srcpkgs(self, opts, newpkg)
+            toActOn.extend(self.bestPackagesFromList(srcpkg, 'src'))
 
         for srpm in toActOn:
             self.logger.info('Getting requirements for %s' % srpm)