[yum-git] 2 commits - plugins/remove-with-leaves

[Seth Vidal]

 plugins/remove-with-leaves/remove-with-leaves.py |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 09ec1dc02e3c36574b88062a6ae3be7d3c2d7f7f
Merge: 708a47a... 431f220...
Author: Seth Vidal <skvidal at fedoraproject.org>
Date:   Fri Sep 19 03:55:07 2008 -0400

    Merge branch 'master' of ssh://login.linux.duke.edu/home/groups/yum/git/yum-utils
    
    * 'master' of ssh://login.linux.duke.edu/home/groups/yum/git/yum-utils:
      Don't hide download errors in downloadonly mode
      updated ChangeLog
      bumped yum-utils version to 1.1.17
      Use calcColumns in keys plugin
      Pass used_map to _has_id from ysp_should_filter_pkg, fixes bug 462372

commit 708a47a6c5fe2bd9022b9a9824fc1e89a1524ff4
Author: Seth Vidal <skvidal at fedoraproject.org>
Date:   Fri Sep 19 03:54:50 2008 -0400

    document the fixme a bit better

diff --git a/plugins/remove-with-leaves/remove-with-leaves.py b/plugins/remove-with-leaves/remove-with-leaves.py
index 81af6fb..5b3d710 100644
--- a/plugins/remove-with-leaves/remove-with-leaves.py
+++ b/plugins/remove-with-leaves/remove-with-leaves.py
@@ -16,6 +16,12 @@
 # Copyright 2008 Red Hat, Inc
 # written by Seth Vidal <skvidal at fedoraproject.org>
 
+#FIXME:
+# When two requirements of a pkg being removed mutually require each other
+# there's no way to have one know about the other and have this know to remove both
+# ex: foo is being removed. it requires bar. bar requires baz. baz requires bar. 
+#     nothing other than foo and baz require bar. 
+
 """
 This plugin allows packages to clean up dependencies they pulled in which are
 not in use by any other package.
@@ -77,9 +83,6 @@ def postresolve_hook(conduit):
                         if req_pkgtup not in pkgtups:
                             non_removed_requires.append(req_pkgtup)
 
-                    #FIXME - go through the non_removed_requires and see if any of them are in the list of 
-                    #        requirements, too
-
                     if not non_removed_requires:
                         conduit.info(2, 'removing %s. It is not required by anything else.' % pkg)
                         conduit._base.remove(pkg)