[PATCH] depsolve: avoid fragile join/split

Dan Kenigsberg danken at redhat.com
Thu Jan 30 09:10:27 UTC 2014


Currently, in a certain flow of
depsolve.Depsolve._requiringFromTransaction(), the code joins (name,
needflags, needversion) into an undelimited string, only to try to split
it back within misc.string_to_prco_tuple().

I would not claim that I understand the whole sequence, but please
consider taking this or something like it.
---
 yum/depsolve.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/yum/depsolve.py b/yum/depsolve.py
index 95c21bc..57cf379 100644
--- a/yum/depsolve.py
+++ b/yum/depsolve.py
@@ -720,7 +720,7 @@ class Depsolve(object):
         else:
             self.verbose_logger.debug(_('TSINFO: Marking %s as install for %s'), best,
                 requiringPo)
-            reqtuple = misc.string_to_prco_tuple(needname + str(needflags) + needversion)
+            reqtuple = misc.string_to_prco_tuple(requirement)
             txmbrs = self.install(best, provides_for=reqtuple)
             for txmbr in txmbrs:
                 txmbr.setAsDep(po=requiringPo)
-- 
1.8.5.3



More information about the Yum-devel mailing list