[PATCH] yumdownloader: use stock doUtilYumSetup()

James Antill james at fedoraproject.org
Mon Jan 20 05:33:37 UTC 2014


On Fri, 2014-01-17 at 15:09 +0100, Zdenek Pavlas wrote:
> yumdownloader didn't lock the cachedir but it might have
> updated the repository metadata.

 Are these two changes really related?

>  yumdownloader.py | 30 ++++++------------------------
>  1 file changed, 6 insertions(+), 24 deletions(-)
> 
> diff --git a/yumdownloader.py b/yumdownloader.py
> index b491c7f..b448aa8 100755
> --- a/yumdownloader.py
> +++ b/yumdownloader.py
> @@ -100,8 +100,13 @@ class YumDownloader(YumUtilBase):
>          # override all pkgdirs
>          self.conf.downloaddir = opts.destdir
>              
> +        if opts.source:
> +            # Setup source repos
> +            self.arch.archlist.append('src')
> +            self.setupSourceRepos()
> +

 With this one can't we just add the archlist bit to setupSourceRepos
(wherever that is)?

 ACK to both though.



More information about the Yum-devel mailing list