[Yum-devel] [PATCH] Don't encourage users to file a bug in case rpmdb is inconsistent

Jan Zeleny jzeleny at redhat.com
Mon Mar 4 10:41:40 UTC 2013


Dne Pá 1. března 2013 10:48:07, James Antill napsal(a):
> On Fri, 2013-03-01 at 16:11 +0100, Jan Zelený wrote:
> > On 1. 3. 2013 at 09:35:32, James Antill wrote:
> > > On Fri, 2013-03-01 at 09:33 +0100, Jan Zeleny wrote:
> > >> > diff --git a/yum/__init__.py b/yum/__init__.py
> > > > 
> > > > index fd54208..6641454 100644
> > > > --- a/yum/__init__.py
> > > > +++ b/yum/__init__.py
> > > > @@ -6286,8 +6286,12 @@ much more problems).
> > > > 
> > > >                  raise Errors.YumRPMCheckError, retmsgs
> > > >              
> > > >              retmsgs = [_('ERROR with transaction check vs
> > > >              depsolve:')]
> > > >              retmsgs.extend(msgs)
> > > > 
> > > > -            retmsgs.append(_('Please report this error at %s')
> > > > -                                         % self.conf.bugtracker_url)
> > > > +            retmsgs.append(_('This usually indicates pre-existing
> > > > dependency'\ +                             'issues in rpmdb. Please
> > > > run
> > > > rpm -Va --nofiles to '\ +                             'see possible
> > > > issues.'))
> > >  
> > >  This is being output just before we'd automatically run "yum check",
> > > 
> > > which is going to output most of the real problems the rpm -Va will show
> > > (and if it outputs nothing tells the user to try running
> > > "rpm -Va --nofiles --nodigest").
> > 
> > I'm curious, could you please guide me through the code path how this
> > piece of code is reached? I looked at it three times before sending the
> > patch, once more now and I still can't find it.
> 
>  Ahh, looking closer at it now this is from "processTransaction()" ...
> which is the simple public API we have, for Eg.
> 
> http://yum.baseurl.org/wiki/YumCodeSnippet/SimplestTransaction
> 
> ...but isn't used by the yum cli itself (FWIW, it is used by PK though).
> In theory we should add all the missing rpmdb_warn_checks stuff to this
> code path, or merge them (3 years ago) but it's probably better/easier
> to just delete the bugtrack message lines, and add a comment saying why.


Something like this?

Thanks
Jan


diff --git a/yum/__init__.py b/yum/__init__.py
index 
5ae6435bdf8eb0314c753a8a1280809904b56843..5f992a7faac08f27b86fbb60f339d24f4cfc3f40 
100644
--- a/yum/__init__.py
+++ b/yum/__init__.py
@@ -6286,8 +6286,8 @@ much more problems).
                 raise Errors.YumRPMCheckError, retmsgs
             retmsgs = [_('ERROR with transaction check vs depsolve:')]
             retmsgs.extend(msgs) 
-            retmsgs.append(_('Please report this error at %s') 
-                                         % self.conf.bugtracker_url)
+            # Don't encourage users to file a bug here, as this is probably
+            # pre-existing issue in dependendies of installed packages
             raise Errors.YumRPMCheckError,retmsgs
         
         tsConf = {}


More information about the Yum-devel mailing list